fix: forms checkbox to reflect correct model state #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tagged-release/forms-hotfix #738 +/- ##
===============================================================
- Coverage 91.32% 91.31% -0.01%
===============================================================
Files 102 102
Lines 3998 3997 -1
Branches 1116 1115 -1
===============================================================
- Hits 3651 3650 -1
Misses 325 325
Partials 22 22
Continue to review full report at Codecov.
|
cwoolum
reviewed
Nov 2, 2022
packages/codegen-ui/lib/__tests__/generate-form-definition/helpers/form-field.test.ts
Show resolved
Hide resolved
cwoolum
approved these changes
Nov 3, 2022
Jshhhh
approved these changes
Nov 3, 2022
Jshhhh
pushed a commit
that referenced
this pull request
Nov 3, 2022
Co-authored-by: Scott Young <scoyou@amazon.com>
Merged
hein-j
pushed a commit
that referenced
this pull request
Nov 3, 2022
Co-authored-by: Scott Young <scoyou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Make CheckboxField a controlled component similar to ToggleButton so that the field properly renders a default state of "checked" when it's supposed to.
Update form setting checkbox to checked, and then reload form
https://user-images.githubusercontent.com/1263887/198681650-ed1fb596-4883-414c-a248-c793194a60fd.mov
Current experience, loading form with checkbox in "checked" state does not set it to checked properly
https://user-images.githubusercontent.com/1263887/198681863-de079ca6-ae7b-42fb-8124-3406ba92d164.mov
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.